containertool: Rename --username/password to --default-username/password #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
--usernameand--passwordoptions define default values which are used if no suitable credentials can be found in.netrc. Their current names could imply that they override other sources of credentials - the help originally said this was the case (#123). Renaming them to--default-usernameand--default-passwordreduces the risk of misunderstanding.Modifications
--userand--passwordoptions to--default-userand--default-password.--helpand remove them from the manual pageResult
Test Plan
All existing test continue to pass.